Why is PHPstan failing?

See lines 91 and 131 in InstallerHelper.php
Refer to:
https://api.joomla.org/cms-5/deprecated.html#repos/joomla-cms/libraries/src/Application/EventAware.php

@BrainforgeUK PHPstan fails because you added another call to the deprecated getDispatcher, so the count for the exclusion in the phpstan-baseline.neon file does not match anymore.

You can fix that by running ./libraries/vendor/bin/phpstan -b on your branch (after having run composer installso that phpstan is available). This will re-create the phpstan-baseline.neon file. Then commit and push the changed file.

P.S.: If you don't have a development environment so you can't do what I recommended in my previous comment, then let me know here and I will do it later.

P.S.: If you don't have a development environment so you can't do what I recommended in my previous comment, then let me know here and I will do it later.

** Yes please, can you do that for me. Thanks.

P.S.: If you don't have a development environment so you can't do what I recommended in my previous comment, then let me know here and I will do it later.

** Yes please, can you do that for me. Thanks.

!! Help have the same issue with #46413 !!

@BrainforgeUK I have checked the PHPstan error message. You can do that, too, by checking the changed files on GitHub.

Maybe you should not use Joomla 3 code in your PRs?

@HLeithner Could you maybe advise here what can be done instead of using the deprecated interface "Joomla\CMS\Application\EventAwareInterface"?

Could you maybe advise here what can be done instead of using the deprecated interface

I am not Harald, but it as i already wrote. Ignore it.
The Application implements 2 interfaces which shares getDispatcher() method:

DispatcherAwareInterface::getDispatcher()

and

EventAwareInterface::getDispatcher()

The EventAwareInterface is deprecated and will be removed, however DispatcherAwareInterface will stay and the getDispatcher() method also will stay.

I think PHPStan cannot distinguish this race condition 😉

I see. Will update phpstan baseline tomorrow.

I've updated the phpstan-baseline.neon file to make PHPstan pass. Basically it is a false alarm by PHPstan, see Fedir's comment above .

Changes in downloadPackage():

I think changes in downloadPackage() method is unnecessary and over complicated.

As I understand the aim is to show to User the error.
This can be done near:

Here we can show server message when it return 403, kind of:

if (200 != $response->getStatusCode()) {
   Log::add(Text::sprintf('JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECT', $response->getStatusCode()), Log::WARNING, 'jerror');

  if (403 === $response->getStatusCode()) {
    $body = (string) $response->getBody();
    // Show response message, but ignore default server error pages
    if ($body && !str_contains($body, '</body>')) {
        //Translate JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_MESSAGE="Error downloading the packge: %1$s. %2$s"
        Log::add(Text::sprintf('JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_MESSAGE', $url, $body), Log::WARNING, 'jerror');
    }
  }

  return false;
}

Nothing special, if the key is wrong Developer just throw 403 on their server and show any text they want to show.
In theory should work simpler than magic JSON.
(We also can check for some response header kind of X-JOOMLA-PACKAGE-MESSAGE, but that can be another "magic" for developers.)

AfterPackageDownloadFailedEvent

This event does not really make sense on first look. If it also just to show message, then probably can be also unnecessary after changes in downloadPackage() method

Added 403 handler as suggested.

Kept JSON response handling and onInstallerAfterPackageDownload event.
Looking at my update server I prefer that flexibility.